[
https://issues.apache.org/jira/browse/COMPRESS-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805786#comment-17805786
]
Vali Maties commented on COMPRESS-656:
--------------------------------------
Hi Gary,
The approach is not so bad as I said above, but some bytes are missing. As I
saw from the SevenZOutputFile class, some bytes are added in the finish()
method, from header and some more buffers, but I have to figure it how to do
it, which of those are the missing bytes.
Besides that, I was a C# developer for some time, and ported to JavaFX couple
of months ago, seems to work faster on multi-threading jobs, the easiness and
flexibility of fxml with css, is gorgeous. So, it is the first time I see these
{_}tests{_}, {_}javadoc{_}, and so on. I did a lot of PRs but no one requires
for test code, descriptors and other things. This means I must lose/{-}waste{-}
some time to figure out how to do this test. JavaDoc I have already added using
IntelliJ Idea, but writing code of test, I must say I don't know what to do
right now. For a while, maybe I will use the snapshot version generated locally
till I figure it out how these PR's work in Java, mostly on this library 😁
> SevenZArchiveEntry getCompressedSize() must be public
> -----------------------------------------------------
>
> Key: COMPRESS-656
> URL: https://issues.apache.org/jira/browse/COMPRESS-656
> Project: Commons Compress
> Issue Type: Improvement
> Components: Compressors
> Affects Versions: 1.25.0
> Reporter: Vali Maties
> Priority: Major
> Labels: SevenZArchiveEntry, entry-compressed-size
> Attachments: EntryCompressedSizePrivate.png, OriginalFileSize.png
>
>
> Please make the compressedSize property of SevenZArchiveEntry as observable
> property with getter. Having this property as observable, we can know in
> anytime the compressed size of an entry. Or maybe only a getter to existing
> compressedSize property.
> I've attached two screenshots with both original file size and the compressed
> size in SevenZArchiveEntry class, running my project in debbug.
>
> _*Edited:*_
> I've saw right now that already exists a getCompressedSize() method, but is
> private. Make that public, to be accessible, please.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
