[
https://issues.apache.org/jira/browse/NET-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804709#comment-17804709
]
Gary D. Gregory commented on NET-726:
-------------------------------------
Hello [~fanningpj]
Feel free to provide a PR on GitHub. Adding getters seems OK but I would not
change the visibility of instance variables.
> make private fields in FTPSClient protected so it can be subclassed
> -------------------------------------------------------------------
>
> Key: NET-726
> URL: https://issues.apache.org/jira/browse/NET-726
> Project: Commons Net
> Issue Type: Task
> Reporter: PJ Fanning
> Priority: Major
>
> As part of https://github.com/apache/incubator-pekko-connectors/pull/171, I
> am trying to subclass FTPSClient to revert the changes in NET-642 (see
> NET-718).
> While the method that I need to change is protected, the method needs access
> to private fields.
> The line I want to revert in the Apache Pekko code is
> https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9R269
>
> That _openDataConnection_ method uses a number of private final fields. Even
> if these fields were provided with protected getter methods, I would be able
> to access the values in my subclass.
> For now, I've done a full copy of FTPSClient and adjusted that - but that is
> a lot of code to keep forked.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
