garydgregory commented on a change in pull request #821:
URL: https://github.com/apache/commons-lang/pull/821#discussion_r734770005
##########
File path: src/main/java/org/apache/commons/lang3/CharSet.java
##########
@@ -147,21 +147,21 @@
*
* <p>All CharSet objects returned by this method will be immutable.</p>
*
- * @param setStrs Strings to merge into the set, may be null
+ * @param set Strings to merge into the set, may be null
* @return a CharSet instance
* @since 2.4
*/
- public static CharSet getInstance(final String... setStrs) {
- if (setStrs == null) {
+ public static CharSet getInstance(final String... set) {
+ if (set == null) {
Review comment:
Uh? An array is not a set.
##########
File path: src/main/java/org/apache/commons/lang3/text/StrBuilder.java
##########
@@ -617,13 +617,13 @@ public StrBuilder append(final String str, final int
startIndex, final int lengt
* Calls {@link String#format(String, Object...)} and appends the result.
*
* @param format the format string
- * @param objs the objects to use in the format string
+ * @param values the objects to use in the format string
* @return {@code this} to enable chaining
* @see String#format(String, Object...)
* @since 3.2
*/
- public StrBuilder append(final String format, final Object... objs) {
- return append(String.format(format, objs));
+ public StrBuilder append(final String format, final Object... values) {
+ return append(String.format(format, values));
Review comment:
"values" is no better IMO. It would be consistent with `String.format()`
to use "args" since we are just passing the values along.
##########
File path: src/main/java/org/apache/commons/lang3/reflect/ConstructorUtils.java
##########
@@ -254,20 +254,20 @@ public ConstructorUtils() {
* (1) Class.getConstructors() is documented to return Constructor<T>
so as
* long as the array is not subsequently modified, everything's fine.
*/
- final Constructor<?>[] ctors = cls.getConstructors();
+ final Constructor<?>[] constructors = cls.getConstructors();
// return best match:
- for (Constructor<?> ctor : ctors) {
+ for (Constructor<?> ctr : constructors) {
Review comment:
Uh? Above, you change "ctor" to "constructor" but here you are changing
_to_ an even short weirder name "ctr"? Be consistent, please.
##########
File path: src/main/java/org/apache/commons/lang3/Streams.java
##########
@@ -246,7 +246,7 @@ public void forEach(final FailableConsumer<O, ?> action) {
*
* @param <R> type of the result
* @param <A> Type of the accumulator.
- * @param pupplier a function that creates a new result container. For
a
+ * @param supplier a function that creates a new result container. For
a
Review comment:
Good catch! :-)
##########
File path: src/main/java/org/apache/commons/lang3/text/StrBuilder.java
##########
@@ -1001,13 +1001,13 @@ public StrBuilder appendln(final String str, final int
startIndex, final int len
* Calls {@link String#format(String, Object...)} and appends the result.
*
* @param format the format string
- * @param objs the objects to use in the format string
+ * @param values the objects to use in the format string
* @return {@code this} to enable chaining
* @see String#format(String, Object...)
* @since 3.2
*/
- public StrBuilder appendln(final String format, final Object... objs) {
- return append(format, objs).appendNewLine();
+ public StrBuilder appendln(final String format, final Object... values) {
+ return append(format, values).appendNewLine();
Review comment:
See above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
