garydgregory commented on a change in pull request #821:
URL: https://github.com/apache/commons-lang/pull/821#discussion_r734769241



##########
File path: src/main/java/org/apache/commons/lang3/AnnotationUtils.java
##########
@@ -69,9 +69,9 @@
          */
         @Override
         protected String getShortClassName(final Class<?> cls) {
-            for (final Class<?> iface : ClassUtils.getAllInterfaces(cls)) {
-                if (Annotation.class.isAssignableFrom(iface)) {
-                    return "@" + iface.getName();
+            for (final Class<?> interfaces : ClassUtils.getAllInterfaces(cls)) 
{

Review comment:
       This is a bad name because this is a singular object.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to