[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311798#comment-16311798
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2365: 
CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159720475
 
 

 ##########
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##########
 @@ -2630,6 +2631,22 @@ public VDI getIsoVDIByURL(final Connection conn, final 
String vmName, final Stri
         }
     }
 
+    private String actualIsoTemplate(final Connection conn) throws 
BadServerResponse, XenAPIException, XmlRpcException {
 
 Review comment:
   We do not need a real host. We only want to test the logic. Therefore, you 
can mock the method calls. PowerMockito and Mockito are there for this kind of 
job.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10197
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.10.0.0
>         Environment: XenServer 7.0+
>            Reporter: Khosrow Moossavi
>             Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to 
> *guest-tools* so CloudStack fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso 
> virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e 
> id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to