[ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311699#comment-16311699 ]
ASF GitHub Bot commented on CLOUDSTACK-10197: --------------------------------------------- rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159707924 ########## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java ########## @@ -536,7 +536,7 @@ private void createXsToolsISO() { id = _tmpltDao.getNextInSequence(Long.class, "id"); VMTemplateVO template = VMTemplateVO.createPreHostIso(id, isoName, isoName, ImageFormat.ISO, true, true, TemplateType.PERHOST, null, null, true, 64, Account.ACCOUNT_ID_SYSTEM, - null, "xen-pv-drv-iso", false, 1, false, HypervisorType.XenServer); + null, "XenServer Tools Installer ISO (xen-pv-drv-iso)", false, 1, false, HypervisorType.XenServer); Review comment: I think this is the right thing to do, so we get consistency. You have to save the `tmplt` as well right? So, you update the data in the database ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs > --------------------------------------------------------------- > > Key: CLOUDSTACK-10197 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Affects Versions: 4.10.0.0 > Environment: XenServer 7.0+ > Reporter: Khosrow Moossavi > Fix For: Future > > > In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to > *guest-tools* so CloudStack fails to attach it to any VM. > {code} > (acs-admin) > attach iso > virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e > id=e8a56540-0fc3-44de-9911-635d2d8f25c4 > errorcode = 530 > errortext = Failed to attach iso > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)