[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969213#comment-15969213
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9877:
--------------------------------------------

Github user serg38 commented on the issue:

    https://github.com/apache/cloudstack/pull/2044
  
    @DaanHoogland Not for us since we still use link clones but I am sure tons 
of other might be affected. Interestingly enough that with PR 1773 merged the 
default behavior in API is not to allow template deletion if there are active 
VMs and only if 'forced' flag is used it will be executed
    # c is an option already but I suggest one of the following
    #d introduce another global config with default value = false e.g. 
vmware.cleanup.fullclonedtemplate that would be a switch old/new behaviur in 
combination with storage.template.cleanup.enabled
    #e make 0 as a default value for vmware.full.clone.template.cleanup.period 
and when you  interpret 0 it means that full clone cleanup thread thread never
    
    #e seems to be a good compromise that doesn't require too many changes


> remove fully cloned deleted templates from primary storage
> ----------------------------------------------------------
>
>                 Key: CLOUDSTACK-9877
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9877
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: VMware
>         Environment: cloudstack with vcentre and the use of "full clones"
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>
> After a template has been deleted from cloudstack and it has only been used 
> with the 'vmware.create.full.clone' setting, it can be cleared from primary 
> storage.
> test notes:
> related settings:
> vmware.full.clone.template.cleanup.period = '1' (minutes, '86400')
> vmware.create.full.clone = 'true' (boolean, 'false')
> storage.template.cleanup.enabled = 'true' (boolean, 'false')
> storage.cleanup.interval = '150' (seconds, default)
> storage.cleanup.enabled = 'true' (boolean, default)
> to test:
>     a vm can be created using the default template or any template installed 
> for this purpose.
>         I'll call it the install-template
>     The vm should be created with a full clone of the template.
>         This can be checked in the table cloud.user_vm_clone_setting
>     The install-template should be copied to the primary store of the host it 
> is on
>         This can be checked in the table cloud.template_spool_ref
>     delete the install-template from the system
>     after at most a minute the entries in cloud.template_spool_ref for the 
> install-template should have the field marked_for_gc set to '1'
>     At most a minute and a half after that the field state in the same record 
> should be set to 'Destroyed'
>     to double check one might go to the mount for this primary storage and 
> seek the installpath to make sure the disk space is actually freed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to