[
https://issues.apache.org/jira/browse/CLOUDSTACK-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969094#comment-15969094
]
ASF GitHub Bot commented on CLOUDSTACK-9877:
--------------------------------------------
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/2044
@DaanHoogland Can you clarify few questions/concerns
1. This change will likely to break restoreVirtualMachine functions. At the
very least users should be able to turn off new behavior with a global setting
that will enable/disable such cleanup.
2. Does this affect a normal template cleanup that will delete both full
and linked clone templates from PS when all VMs that use them are gone?
3. You introduce vmware.full.clone.template.cleanup.period as vmware
specific setting. Is this only applicable to vmware?
4. Some changes are done to Vmware-Host-Scan task that seems to be
unrelated to scope of this PR.
> remove fully cloned deleted templates from primary storage
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-9877
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9877
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: VMware
> Environment: cloudstack with vcentre and the use of "full clones"
> Reporter: Daan Hoogland
> Assignee: Daan Hoogland
>
> After a template has been deleted from cloudstack and it has only been used
> with the 'vmware.create.full.clone' setting, it can be cleared from primary
> storage.
> test notes:
> related settings:
> vmware.full.clone.template.cleanup.period = '1' (minutes, '86400')
> vmware.create.full.clone = 'true' (boolean, 'false')
> storage.template.cleanup.enabled = 'true' (boolean, 'false')
> storage.cleanup.interval = '150' (seconds, default)
> storage.cleanup.enabled = 'true' (boolean, default)
> to test:
> a vm can be created using the default template or any template installed
> for this purpose.
> I'll call it the install-template
> The vm should be created with a full clone of the template.
> This can be checked in the table cloud.user_vm_clone_setting
> The install-template should be copied to the primary store of the host it
> is on
> This can be checked in the table cloud.template_spool_ref
> delete the install-template from the system
> after at most a minute the entries in cloud.template_spool_ref for the
> install-template should have the field marked_for_gc set to '1'
> At most a minute and a half after that the field state in the same record
> should be set to 'Destroyed'
> to double check one might go to the mount for this primary storage and
> seek the installpath to make sure the disk space is actually freed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
