[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741834#comment-14741834
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8817:
--------------------------------------------

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/810#issuecomment-139698329
  
    @ashwinswaroop, no problem. 
    About the class duplicity, it just seems that there are two classes, but in 
reality there is only one. The question is that the project cloudstack-api is 
located inside the Cloudstack (it is a module). You should open the class that 
appear to be in cloudstack-api, this way the Eclipse IDE will properly compile 
and show the errors that the class might have.
    
    Sure you will have to change every single point that uses those getters and 
setters, if you want to proceed with that proposal.
    
    I just asked about the IDE, because when I saw that you just changed the 
parameters type, but not the setters and getters, it seemed like someone using 
VI to edit source files.



> listFirewallRules response JSON startport/endport not an int
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8817
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8817
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API
>    Affects Versions: 4.6.0
>            Reporter: René Moser
>            Priority: Trivial
>
> h2. Summary
> listFirewallRules returns endpoint and startpoint values as String.
> h2. Excpected results
> {code}
> {
>   "count": 1 
>   "firewallrule": [
>     {
>       "cidrlist": "0.0.0.0/0", 
>       "endport": 22, 
>       "fordisplay": true, 
>       "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03", 
>       "ipaddress": "10.101.0.21", 
>       "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21", 
>       "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a", 
>       "protocol": "tcp", 
>       "startport": 22, 
>       "state": "Active", 
>       "tags": []
>     }
>   ]
> }
> {code}
> h2. Actuall results
> {code}
> {
>   "count": 1 
>   "firewallrule": [
>     {
>       "cidrlist": "0.0.0.0/0", 
>       "endport": "22", 
>       "fordisplay": true, 
>       "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03", 
>       "ipaddress": "10.101.0.21", 
>       "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21", 
>       "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a", 
>       "protocol": "tcp", 
>       "startport": "22", 
>       "state": "Active", 
>       "tags": []
>     }
>   ]
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to