[
https://issues.apache.org/jira/browse/CLOUDSTACK-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741646#comment-14741646
]
ASF GitHub Bot commented on CLOUDSTACK-8817:
--------------------------------------------
GitHub user ashwinswaroop opened a pull request:
https://github.com/apache/cloudstack/pull/810
This is the fix for the JIRA issue CLOUDSTACK-8817.
This is my first contribution to Apache CloudStack. The return values for
endpoint and startpoint have now been changed to Integer instead of String.
Please let me know if this is the only change that is required or if there are
additional files which will be impacted by this change which require
modification also.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ashwinswaroop/cloudstack feature_x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/810.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #810
----
commit 4d626c11bc4f029788ddc0e12340d8e880521f8b
Author: Ashwin Swaroop <ashwinswaroo...@gmail.com>
Date: 2015-09-11T22:27:31Z
This is the fix for the JIRA issue CLOUDSTACK-8817. The return values for
endpoint and startpoint are now Integer instead of String.
----
> listFirewallRules response JSON startport/endport not an int
> ------------------------------------------------------------
>
> Key: CLOUDSTACK-8817
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8817
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.6.0
> Reporter: René Moser
> Priority: Trivial
>
> h2. Summary
> listFirewallRules returns endpoint and startpoint values as String.
> h2. Excpected results
> {code}
> {
> "count": 1
> "firewallrule": [
> {
> "cidrlist": "0.0.0.0/0",
> "endport": 22,
> "fordisplay": true,
> "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03",
> "ipaddress": "10.101.0.21",
> "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21",
> "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a",
> "protocol": "tcp",
> "startport": 22,
> "state": "Active",
> "tags": []
> }
> ]
> }
> {code}
> h2. Actuall results
> {code}
> {
> "count": 1
> "firewallrule": [
> {
> "cidrlist": "0.0.0.0/0",
> "endport": "22",
> "fordisplay": true,
> "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03",
> "ipaddress": "10.101.0.21",
> "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21",
> "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a",
> "protocol": "tcp",
> "startport": "22",
> "state": "Active",
> "tags": []
> }
> ]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
