[
https://issues.apache.org/jira/browse/CALCITE-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526147#comment-17526147
]
Chunwei Lei commented on CALCITE-5091:
--------------------------------------
Makes sense. The PR looks good to me.
> RelMdRowCount can return more accurate rowCount when fetch is deterministic
> and offset is dynamic
> -------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5091
> URL: https://issues.apache.org/jira/browse/CALCITE-5091
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.30.0
> Reporter: Jiajun Xie
> Assignee: Jiajun Xie
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The sql from CALCITE-5048
> {code:java}
> select * from emp order by ename limit 1 offset ?
> {code}
> *RelMdRowCount#getRowCount* will return 14d, because it always return
> rowCount when offset is dynamic.
> {code:java}
> if (rel.offset instanceof RexDynamicParam) {
> return rowCount;
> }
> {code}
> Obviously, rowCount will not exceed 1 because *LIMIT 1*. We can improve it.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
