[ 
https://issues.apache.org/jira/browse/CALCITE-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520872#comment-17520872
 ] 

Jiajun Xie edited comment on CALCITE-5091 at 4/12/22 1:19 AM:
--------------------------------------------------------------

I will submit PR after this ticket is solved.


was (Author: jiajunbernoulli):
I will submit PR when this 
[ticket|https://issues.apache.org/jira/browse/CALCITE-5048] is solved

> RelMdRowCount can return more accurate rowCount when fetch is deterministic 
> and offset is dynamic
> -------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5091
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5091
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.30.0
>            Reporter: Jiajun Xie
>            Assignee: Jiajun Xie
>            Priority: Minor
>
> The sql from https://issues.apache.org/jira/browse/CALCITE-5048
> {code:java}
> select * from emp order by ename limit 1 offset ?
> {code}
> *RelMdRowCount#getRowCount* will return 14d, because it always return 
> rowCount when offset is dynamic.
> {code:java}
>     if (rel.offset instanceof RexDynamicParam) {
>       return rowCount;
>     }
> {code}
> Obviously, rowCount will not exceed 1 because *LIMIT 1*. We can improve it.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to