[
https://issues.apache.org/jira/browse/CALCITE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799142#comment-16799142
]
Hongze Zhang commented on CALCITE-883:
--------------------------------------
To me your code pasted above makes sense already. Otherwise maybe we can just
make change to the SqlNode "SqlWindow" (but it is maybe a little tricky since
the tokens <IGNORE/RESPECT> <NULLS> should be at the lhs of the window
expansion). And I can share some code later since I'm now on a vacation.
Basically my point is to at least avoid changes to SqlCall/SqlBasicCall if
possible, to keep them simple and easy to construct. Do you think it is really
necessary to add the field the these classes?
> Support RESPECT NULLS, IGNORE NULLS option for LEAD, LAG, FIRST_VALUE,
> LAST_VALUE window functions
> --------------------------------------------------------------------------------------------------
>
> Key: CALCITE-883
> URL: https://issues.apache.org/jira/browse/CALCITE-883
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Sean Hsuan-Yi Chu
> Assignee: Chunwei Lei
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This issue was brought up in Drill community:
> (https://issues.apache.org/jira/browse/DRILL-3597)
> For convenience, I copied and pasted the reporter Khurram Faraaz's
> description here:
> "The SQL standard defines a RESPECT NULLS or IGNORE NULLS option for lead,
> lag, first_value, and last_value window functions."
> In Calcite, we should have been able to recognized this option.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
