[ 
https://issues.apache.org/jira/browse/CALCITE-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624065#comment-16624065
 ] 

Vladimir Sitnikov commented on CALCITE-2582:
--------------------------------------------

TL;DR: It does look like moving stuff from FilterProjectTransposeRule to 
RelBuilder is desired.

I'm not sure {{copying(RelNode, Function)}} is easy to use and implement API 
({{RelNode#getFactory}} would me harder than current {{copy}} methods).
I'm not sure we can figure proper full-RelBuilder API before 1.18, so I suggest 
we go with something like 
https://issues.apache.org/jira/browse/CALCITE-2582?focusedCommentId=16623397&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16623397
 , and iterate on RelBuilder later.

Does that work for you?


> FilterProjectTransposeRule does not always simplify the new filter condition
> ----------------------------------------------------------------------------
>
>                 Key: CALCITE-2582
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2582
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: 1.18.0
>
>
> After pushing the filter below the project a new condition is going to be 
> generated along with a new Filter operator. The new condition is not going to 
> be simplified if the filter operator is copied and not created using the 
> RelBuilder. 
> Thus the resulting plan may contain redundant conditions which can have a 
> slight impact on performance. Apart, from that tests verifying the resulting 
> (logical/physical) plan may produce indeterministic results if the rule is 
> applied with (a different order and in combination with other rules). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to