[
https://issues.apache.org/jira/browse/BEAM-14536?focusedWorklogId=776515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776515
]
ASF GitHub Bot logged work on BEAM-14536:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/22 19:13
Start Date: 31/May/22 19:13
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17782:
URL: https://github.com/apache/beam/pull/17782#discussion_r886038681
##########
sdks/go/pkg/beam/core/runtime/exec/sdf.go:
##########
@@ -678,10 +678,6 @@ func (n *ProcessSizedElementsAndRestrictions) Checkpoint()
([]*FullValue, error)
return nil, addContext(err)
}
- if !n.rt.IsDone() {
- return nil, addContext(errors.Errorf("Primary restriction %#v
is not done. Check that the RTracker's TrySplit() at fraction 0.0 returns a
completed primary restriction", n.rt))
- }
Review Comment:
I had to remove this check because the new splitting logic ends up setting
`rest.End = rest.claimed + 1`. Since the claimed work _should_ be complete,
this means that the restriction is done, but that condition can't be checked
here without adding new methods for users to implement (which doesn't seem
worth it).
Issue Time Tracking
-------------------
Worklog Id: (was: 776515)
Time Spent: 2h 20m (was: 2h 10m)
> Offsetrange tracker panics when splitting at 0.0 without claiming work
> ----------------------------------------------------------------------
>
> Key: BEAM-14536
> URL: https://issues.apache.org/jira/browse/BEAM-14536
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Danny McCormick
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Right now, if you try to call TrySplit on an offsetrange restriction with a
> fraction of 0.0 and without first claiming work, it sets the primary
> restriction to \{Start, Start-1}. This causes newSplitResult to panic -
> https://github.com/apache/beam/blob/ff39fcb5229b15140e41a61bd09f7d590730e93a/sdks/go/pkg/beam/core/runtime/exec/sdf.go#L859
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
