[ 
https://issues.apache.org/jira/browse/BEAM-14536?focusedWorklogId=776436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776436
 ]

ASF GitHub Bot logged work on BEAM-14536:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/22 16:35
            Start Date: 31/May/22 16:35
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] commented on PR #17782:
URL: https://github.com/apache/beam/pull/17782#issuecomment-1142366597

   # 
[Codecov](https://codecov.io/gh/apache/beam/pull/17782?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#17782](https://codecov.io/gh/apache/beam/pull/17782?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (57bb99c) into 
[master](https://codecov.io/gh/apache/beam/commit/4d22202fde91d5bc0b73369de39e4f4baa49739e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (4d22202) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #17782   +/-   ##
   =======================================
     Coverage   74.02%   74.02%           
   =======================================
     Files         695      695           
     Lines       91872    91875    +3     
   =======================================
   + Hits        68007    68010    +3     
     Misses      22619    22619           
     Partials     1246     1246           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | go | `50.49% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/17782?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...o/pkg/beam/io/rtrackers/offsetrange/offsetrange.go](https://codecov.io/gh/apache/beam/pull/17782/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9ydHJhY2tlcnMvb2Zmc2V0cmFuZ2Uvb2Zmc2V0cmFuZ2UuZ28=)
 | `76.36% <100.00%> (+0.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/17782?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/17782?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[4d22202...57bb99c](https://codecov.io/gh/apache/beam/pull/17782?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 776436)
    Time Spent: 1h  (was: 50m)

> Offsetrange tracker panics when splitting at 0.0 without claiming work
> ----------------------------------------------------------------------
>
>                 Key: BEAM-14536
>                 URL: https://issues.apache.org/jira/browse/BEAM-14536
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Danny McCormick
>            Assignee: Danny McCormick
>            Priority: P2
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Right now, if you try to call TrySplit on an offsetrange restriction with a 
> fraction of 0.0 and without first claiming work, it sets the primary 
> restriction to \{Start, Start-1}. This causes newSplitResult to panic - 
> https://github.com/apache/beam/blob/ff39fcb5229b15140e41a61bd09f7d590730e93a/sdks/go/pkg/beam/core/runtime/exec/sdf.go#L859



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to