[jira] [Work logged] (BEAM-13429) [Playground] Improve preparators by the introducing of builder

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-13429?focusedWorklogId=708386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708386
 ]

ASF GitHub Bot logged work on BEAM-13429:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jan/22 15:01
            Start Date: 13/Jan/22 15:01
    Worklog Time Spent: 10m 
      Work Description: daria-malkova commented on a change in pull request 
#16482:
URL: https://github.com/apache/beam/pull/16482#discussion_r784040622



##########
File path: playground/backend/internal/preparers/java_preparators_test.go
##########
@@ -88,25 +88,39 @@ func Test_replace(t *testing.T) {
        }
 }
 
-func TestGetJavaPreparators(t *testing.T) {
+func TestGetJavaPreparers(t *testing.T) {
        type args struct {
-               filePath string
+               filePath   string
+               isUnitTest bool
+               isKata     bool
        }
        tests := []struct {
                name string
                args args
                want int
        }{
                {
-                       name: "all success",
-                       args: args{"MOCK_FILEPATH"},
-                       want: 4,
+                       name: "Test number of preparers for code",
+                       args: args{"MOCK_FILEPATH", false, false},
+                       want: 2,
+               },
+               {
+                       name: "Test number of preparers for unit test",
+                       args: args{"MOCK_FILEPATH", false, false},
+                       want: 2,
+               },
+               {
+                       name: "Test number of preparers for kata",
+                       args: args{"MOCK_FILEPATH", false, false},

Review comment:
       Done

##########
File path: playground/backend/internal/preparers/preparator.go
##########
@@ -13,10 +13,38 @@
 // See the License for the specific language governing permissions and

Review comment:
       Done

##########
File path: playground/backend/internal/preparers/python_preparators.go
##########
@@ -13,7 +13,7 @@
 // See the License for the specific language governing permissions and

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 708386)
    Time Spent: 2h  (was: 1h 50m)

>  [Playground] Improve preparators by the introducing of builder
> ---------------------------------------------------------------
>
>                 Key: BEAM-13429
>                 URL: https://issues.apache.org/jira/browse/BEAM-13429
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-playground
>            Reporter: Daria Malkova
>            Assignee: Daria Malkova
>            Priority: P3
>              Labels: beam-playground-backend, beam-playground-sprint-6, 
> beam-playground-sprint-7
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Investigate and implement (if need) a usage of a builder for preparators to 
> construct the necessary builders for each SDK/unit-test/not-unit-test



--
This message was sent by Atlassian Jira
(v8.20.1#820001)