[
https://issues.apache.org/jira/browse/BEAM-13429?focusedWorklogId=708173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708173
]
ASF GitHub Bot logged work on BEAM-13429:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/22 10:14
Start Date: 13/Jan/22 10:14
Worklog Time Spent: 10m
Work Description: daria-malkova commented on a change in pull request
#16482:
URL: https://github.com/apache/beam/pull/16482#discussion_r783815086
##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -41,47 +39,85 @@ const (
publicClassNamePattern = "public class (.*?)
[{|implements(.*)]"
)
-// GetJavaPreparators returns preparation methods that should be applied to
Java code
-func GetJavaPreparators(filePath string) *[]Preparator {
+//JavaPreparersBuilder facet of PreparersBuilder
+type JavaPreparersBuilder struct {
+ PreparersBuilder
+}
+
+//JavaPreparers chains to type *PreparersBuilder and returns a
*JavaPreparersBuilder
+func (b *PreparersBuilder) JavaPreparers() *JavaPreparersBuilder {
+ return &JavaPreparersBuilder{*b}
+}
+
+//WithPublicClassRemover adds preparer to remove public class
+func (a *JavaPreparersBuilder) WithPublicClassRemover() *JavaPreparersBuilder {
removePublicClassPreparator := Preparator{
Prepare: removePublicClassModifier,
- Args: []interface{}{filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
+ Args: []interface{}{a.filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
}
+ a.AddPreparer(removePublicClassPreparator)
+ return a
+}
+
+//WithPackageChanger adds preparer to change package
+func (a *JavaPreparersBuilder) WithPackageChanger() *JavaPreparersBuilder {
changePackagePreparator := Preparator{
Prepare: changePackage,
- Args: []interface{}{filePath, packagePattern,
importStringPattern},
+ Args: []interface{}{a.filePath, packagePattern,
importStringPattern},
}
+ a.AddPreparer(changePackagePreparator)
+ return a
+}
+
+//WithPackageRemover adds preparer to remove package
+func (a *JavaPreparersBuilder) WithPackageRemover() *JavaPreparersBuilder {
removePackagePreparator := Preparator{
Prepare: removePackage,
- Args: []interface{}{filePath, packagePattern,
newLinePattern},
+ Args: []interface{}{a.filePath, packagePattern,
newLinePattern},
}
+ a.AddPreparer(removePackagePreparator)
+ return a
+}
+
+//WithFileNameChanger adds preparer to remove package
+func (a *JavaPreparersBuilder) WithFileNameChanger() *JavaPreparersBuilder {
unitTestFileNameChanger := Preparator{
Prepare: changeJavaTestFileName,
- Args: []interface{}{filePath},
+ Args: []interface{}{a.filePath},
+ }
+ a.AddPreparer(unitTestFileNameChanger)
+ return a
+}
+
+// GetJavaPreparators returns preparation methods that should be applied to
Java code
+func GetJavaPreparators(builder *PreparersBuilder, isUnitTest bool, isKata
bool) {
Review comment:
Done
##########
File path: playground/backend/internal/preparators/python_preparators.go
##########
@@ -27,12 +27,30 @@ const (
)
// GetPythonPreparators returns preparation methods that should be applied to
Python code
-func GetPythonPreparators(filePath string) *[]Preparator {
+func GetPythonPreparators(builder *PreparersBuilder) {
Review comment:
Donce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 708173)
Time Spent: 20m (was: 10m)
> [Playground] Improve preparators by the introducing of builder
> ---------------------------------------------------------------
>
> Key: BEAM-13429
> URL: https://issues.apache.org/jira/browse/BEAM-13429
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Daria Malkova
> Assignee: Daria Malkova
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-6,
> beam-playground-sprint-7
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Investigate and implement (if need) a usage of a builder for preparators to
> construct the necessary builders for each SDK/unit-test/not-unit-test
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
