[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=538651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538651
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/21 19:44
Start Date: 20/Jan/21 19:44
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on a change in pull request
#13667:
URL: https://github.com/apache/beam/pull/13667#discussion_r561224392
##########
File path: runners/samza/job-server/build.gradle
##########
@@ -32,7 +32,6 @@ applyJavaNature(
)
dependencies {
- compile project(":runners:samza")
Review comment:
RIght, this is the same as Flink and Spark job server. I was using
runShadow task to bring up the job server locally, and plan to add portability
tests later.
##########
File path: runners/samza/build.gradle
##########
@@ -53,21 +54,28 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.commons_io
- compile library.java.commons_lang3
- compile library.java.args4j
- compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "io.dropwizard.metrics:metrics-core:3.1.2"
compile "org.rocksdb:rocksdbjni:5.7.3"
- compile "org.apache.commons:commons-collections4:4.0"
compile "org.scala-lang:scala-library:2.11.8"
compile "org.apache.samza:samza-api:$samza_version"
compile "org.apache.samza:samza-core_2.11:$samza_version"
compile "org.apache.samza:samza-kafka_2.11:$samza_version"
compile "org.apache.samza:samza-kv_2.11:$samza_version"
+ compile project(":sdks:java:expansion-service")
+ permitUnusedDeclared "org.apache.samza:samza-kafka_2.11:1.5.0"
Review comment:
Makes sense. Most of them are used in runtime. I am not sure why the
samza-kv_2.11 module needs to be permitUnusedDeclared, as it contains Samza's
state backend api and we use it in the runner's state internals impl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538651)
Time Spent: 64h 20m (was: 64h 10m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 64h 20m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
