[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=538606&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538606
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/21 18:41
Start Date: 20/Jan/21 18:41
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13667:
URL: https://github.com/apache/beam/pull/13667#discussion_r561187562
##########
File path: runners/samza/job-server/build.gradle
##########
@@ -32,7 +32,6 @@ applyJavaNature(
)
dependencies {
- compile project(":runners:samza")
Review comment:
If this is the same as the Flink and Spark job servers, this dependency
is actually needed somehow (I haven't figured out how yet). So I think it's
fine to keep the compile dependency and add `permitUnusedDeclared` for now.
##########
File path: runners/samza/build.gradle
##########
@@ -53,21 +54,28 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.commons_io
- compile library.java.commons_lang3
- compile library.java.args4j
- compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "io.dropwizard.metrics:metrics-core:3.1.2"
compile "org.rocksdb:rocksdbjni:5.7.3"
- compile "org.apache.commons:commons-collections4:4.0"
compile "org.scala-lang:scala-library:2.11.8"
compile "org.apache.samza:samza-api:$samza_version"
compile "org.apache.samza:samza-core_2.11:$samza_version"
compile "org.apache.samza:samza-kafka_2.11:$samza_version"
compile "org.apache.samza:samza-kv_2.11:$samza_version"
+ compile project(":sdks:java:expansion-service")
+ permitUnusedDeclared "org.apache.samza:samza-kafka_2.11:1.5.0"
Review comment:
I'm guessing many/all of these `permitUnusedDeclared` dependencies
should be `runtimeOnly` instead of `compile`+`permitUnusedDeclared`. But I will
let someone with more knowledge of the Samza runner say for sure.
##########
File path: runners/samza/build.gradle
##########
@@ -53,21 +54,28 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.commons_io
- compile library.java.commons_lang3
- compile library.java.args4j
- compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "io.dropwizard.metrics:metrics-core:3.1.2"
compile "org.rocksdb:rocksdbjni:5.7.3"
- compile "org.apache.commons:commons-collections4:4.0"
compile "org.scala-lang:scala-library:2.11.8"
compile "org.apache.samza:samza-api:$samza_version"
compile "org.apache.samza:samza-core_2.11:$samza_version"
compile "org.apache.samza:samza-kafka_2.11:$samza_version"
compile "org.apache.samza:samza-kv_2.11:$samza_version"
+ compile project(":sdks:java:expansion-service")
+ permitUnusedDeclared "org.apache.samza:samza-kafka_2.11:1.5.0"
+ permitUnusedDeclared "org.apache.samza:samza-kv-inmemory_2.11:1.3.0"
+ permitUnusedDeclared "org.apache.samza:samza-kv_2.11:1.5.0"
+ permitUnusedDeclared "org.rocksdb:rocksdbjni:6.5.3"
+ permitUnusedDeclared "org.scala-lang:scala-library:2.11.12"
compile "org.apache.samza:samza-kv-rocksdb_2.11:$samza_version"
compile "org.apache.samza:samza-kv-inmemory_2.11:$samza_version"
compile "org.apache.samza:samza-yarn_2.11:$samza_version"
compile "org.apache.kafka:kafka-clients:0.11.0.2"
+ permitUnusedDeclared "org.apache.kafka:kafka-clients:2.4.1"
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538606)
Time Spent: 62h 40m (was: 62.5h)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 62h 40m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
