gemmellr commented on PR #6205: URL: https://github.com/apache/artemis/pull/6205#issuecomment-3848366025
It doesnt make sense for config reload with the same unchanged config properties to result in a different effective config than startup does from the very same config/properties. Yet for a provided Configuration thats something your changes can do, throwing away the initial configuration in the reloadable sections, totally unlike it does at startup, and unlike what it did before. Thats a far worse behaviour than anything. The embedded "Main" class that was initially aimed at usage with properties to add _additional_ config, to some existing config. That for example supplies the initial broker config as a Configuration object (loaded from an XML file, but not by the broker itself). It uses the EmbeddedActiveMQ to do that, which you also added support for providing a specified properties to go with existing base provided Configuration. The broker itself has for years automatically loaded a properties file (if found) at startup and applies it as _additional configuration_ to whatever the existing passed in (or parsed) Configuration was. Your change will take those same configuration details at reload, potentially completely unchanged, and then do something entirely different with it by tossing the original Configuration in the reloadable sections and using only the effect of the properties alone, resulting in a completely different effective config from the same starting configuration details even tho ugh noe of them actually changed. Something that is currently functioning in a reasonably expected manner, in the way it always worked, and changes to do something thats quite unexpected, and doesnt even say its doing it. Thats what I mean by silently breaking what has been working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
