gemmellr commented on PR #6205: URL: https://github.com/apache/artemis/pull/6205#issuecomment-3847148631
> configurationFileRefreshPeriod=-1 is necessary if there are multiple source of truth for config that supports reload. > configurationFileRefreshPeriod=-1 is necessary if there are multiple source of truth for config that supports reload. This has never been a stated requirement and still wouldnt be enforced (which it should be if its a requirement), and I know you originally added the broker properties to use in a situation there were specifically multiple sources (with updates to each targeting different configuration areas, i.e not overlapping) so that seems strange to say now. I can see it causes problems for your current changes, but I dont think silently breaking stuff that has been working is necessarily the way to go. I also think what these changes would seem to allow in later silently tossing startup configuration would be a worse bug than any consideration of the way it currently behaves as being a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
