[
https://issues.apache.org/jira/browse/IMPALA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060806#comment-18060806
]
ASF subversion and git services commented on IMPALA-14764:
----------------------------------------------------------
Commit 9c734dd5f27c35113ad7c38806e6d1dfd83b2249 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=9c734dd5f ]
IMPALA-14764 (part 2): Fix LLVM's run-clang-tidy.py stderr handling
For some reason, LLVM's run-clang-tidy.py captures the stderr
from Clang Tidy and outputs it to stdout. The important output
about issues goes to stdout. The output to stderr is mostly garbage
like "70 warnings generated". To avoid that pollution, this modifies
the script to send the stderr output to stderr (which we only output
if there is an actual error running clang-tidy itself).
Testing:
- Ran bin/run_clang_tidy.sh on Ubuntu 20 / 22
Change-Id: I6ae90fb12dc222f8fb38b8e563617216ce806f0f
Reviewed-on: http://gerrit.cloudera.org:8080/23991
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Joe McDonnell <[email protected]>
> Vendor run-clang-tidy.py from LLVM
> ----------------------------------
>
> Key: IMPALA-14764
> URL: https://issues.apache.org/jira/browse/IMPALA-14764
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Priority: Major
>
> Currently, the run-clang-tidy.py script (used by the clang-tidy-ub2004
> precommit job) comes from toolchain LLVM. LLVM 5's run-clang-tidy.py doesn't
> support python 3, so it would require patching to run on newer systems like
> Ubuntu 22. Maintaining patches in the toolchain is doable but annoying. Since
> run-clang-tidy.py doesn't really have any dependency on a specific version of
> clang, another option is to vendor the latest version of the script and
> maintain it in our repository directly. This would decouple the script from
> upgrades of LLVM/Clang.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
