[
https://issues.apache.org/jira/browse/IMPALA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060805#comment-18060805
]
ASF subversion and git services commented on IMPALA-14764:
----------------------------------------------------------
Commit adcd14503effd391fb6cc6356fd3a88829a934c4 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=adcd14503 ]
IMPALA-14764 (part 1): Vendor LLVM's run-clang-tidy.py
This pulls in LLVM's latest run-clang-tidy.py from commit hash
b0ce26c320 and switches our runner script to use it. LLVM's
run-clang-tidy.py has verbose progress output by default. This
passes in the -hide-progress flag to turn it off. LLVM uses
Apache 2.0 with an exception. This adds information about that
exception to LICENSE.txt.
Testing:
- Ran bin/run_clang_tidy.sh on Ubuntu 20 / 22
Change-Id: Ia409d0bcdaefc93b81d1f3df278b2e4258122f9c
Reviewed-on: http://gerrit.cloudera.org:8080/23990
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Joe McDonnell <[email protected]>
> Vendor run-clang-tidy.py from LLVM
> ----------------------------------
>
> Key: IMPALA-14764
> URL: https://issues.apache.org/jira/browse/IMPALA-14764
> Project: IMPALA
> Issue Type: Task
> Components: Infrastructure
> Affects Versions: Impala 5.0.0
> Reporter: Joe McDonnell
> Priority: Major
>
> Currently, the run-clang-tidy.py script (used by the clang-tidy-ub2004
> precommit job) comes from toolchain LLVM. LLVM 5's run-clang-tidy.py doesn't
> support python 3, so it would require patching to run on newer systems like
> Ubuntu 22. Maintaining patches in the toolchain is doable but annoying. Since
> run-clang-tidy.py doesn't really have any dependency on a specific version of
> clang, another option is to vendor the latest version of the script and
> maintain it in our repository directly. This would decouple the script from
> upgrades of LLVM/Clang.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
