[
https://issues.apache.org/jira/browse/IMPALA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950478#comment-17950478
]
ASF subversion and git services commented on IMPALA-13930:
----------------------------------------------------------
Commit f2acd2381ffb3d33f5789bc6086b7d821bad4561 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f2acd2381 ]
IMPALA-14039: __restore_query_options should unset query option
ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.
Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.
ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:
SET query_option="";
This patch also change execute_query_using_vector() to simply unset
client's configuration.
Follow up cleanup will be tracked through IMPALA-14060.
Testing:
Run and pass test_queries.py::TestQueries.
Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Reviewed-on: http://gerrit.cloudera.org:8080/22862
Reviewed-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> ImpylaHS2Connection should only open cursor as needed.
> ------------------------------------------------------
>
> Key: IMPALA-13930
> URL: https://issues.apache.org/jira/browse/IMPALA-13930
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 5.0.0
>
>
> Currently, ImpylaHS2Connection open a cursor (and HS2 session) as it connect,
> followed by running "SET ALL" query to populate default query options. It
> should be possible to open cursor only when querying is needed the first
> time. That will help preserve assertion for test that sensitive about client
> connection, like IMPALA-13925.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
