[
https://issues.apache.org/jira/browse/IMPALA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940899#comment-17940899
]
ASF subversion and git services commented on IMPALA-13930:
----------------------------------------------------------
Commit f8e2f2c7db80d244f829457773959e5466e8b93d in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f8e2f2c7d ]
IMPALA-13925: Deflake TestFrontendConnectionLimit
TestFrontendConnectionLimit is flaky after IMPALA-13907. The test
randomly picks one impalad and create multiple clients to connect to
that impalad. However, the test also limits --fe_service_threads=1. If
the random impalad picked is the first impalad, any new client might not
be able to connect because the default ImpalaTestSuite.hs2_client has
open session to the first impalad after running SET ALL query.
ImpalaTestSuite.beeswax_client does not seem to have this issue because
it does not run any query at connect().
This patch attempt to deflake the test by skip the creation of all
default impala clients. Added classmethod need_default_clients() that is
overrideable by test classes that wish to skip default client creation.
Filed IMPALA-13930 to improve ImpylaHS2Connection instantiation.
Testing:
Manually loop the tests for 20 times and pass all of them. Before this
patch, the test can get stuck if looped less than that.
Change-Id: I53c6760f5e3734397746b5a228345c9df38eabcb
Reviewed-on: http://gerrit.cloudera.org:8080/22724
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> ImpylaHS2Connection should only open cursor as needed.
> ------------------------------------------------------
>
> Key: IMPALA-13930
> URL: https://issues.apache.org/jira/browse/IMPALA-13930
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> Currently, ImpylaHS2Connection open a cursor (and HS2 session) as it connect,
> followed by running "SET ALL" query to populate default query options. It
> should be possible to open cursor only when querying is needed the first
> time. That will help preserve assertion for test that sensitive about client
> connection, like IMPALA-13925.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
