On Wed, 20 Jun 2012, 08:43:08 BST, Ludwig Nussel <ludwig.nus...@suse.de> wrote: > > > - CG_Error( "%s", text); > > > + trap_Error( text ); > > > > Don't do that. That's calling for format string issues ie security > > bugs. May not be an issue with ioq3 builtin function (I didn't check) > > but in general keeping the "%s" is correct. Please revert the change. > > Ah, trap_Error isn't actually varargs. It expects the expanded string > already and translates to Com_Error( ERR_DROP, "%s", ... later. So it's > actually ok.
It does seem like change for change's sake though. There is no real benefit to this patch besides a vanishingly minor performance improvement, coupled with the risk of introducing bugs. I'm not saying revert it, but I do question the logic of applying it in the first place. _______________________________________________ ioquake3 mailing list ioquake3@lists.ioquake.org http://lists.ioquake.org/listinfo.cgi/ioquake3-ioquake.org By sending this message I agree to love ioquake3 and libsdl.
