On Thu, Nov 10, 2011 at 8:57 AM, Harley Laue <losinggenerat...@gmail.com>wrote:

> On 11/09/2011 10:49 PM, donotre...@icculus.org wrote:
>
>> Author: ztm
>> Date: 2011-11-09 23:49:07 -0500 (Wed, 09 Nov 2011)
>> New Revision: 2197
>>
>> Modified:
>>    trunk/code/game/g_svcmds.c
>> Log:
>> Added missing newlines to game dedicated chat messages.
>>
>> Modified: trunk/code/game/g_svcmds.c
>> ==============================**==============================**=======
>> --- trunk/code/game/g_svcmds.c  2011-11-05 01:02:35 UTC (rev 2196)
>> +++ trunk/code/game/g_svcmds.c  2011-11-10 04:49:07 UTC (rev 2197)
>> @@ -495,11 +495,11 @@
>>
>>        if (g_dedicated.integer) {
>>                if (Q_stricmp (cmd, "say") == 0) {
>> -                       trap_SendServerCommand( -1, va("print \"server:
>> %s\"", ConcatArgs(1) ) );
>> +                       trap_SendServerCommand( -1, va("print \"server:
>> %s\n\"", ConcatArgs(1) ) );
>>                        return qtrue;
>>                }
>>                // everything else will also be printed as a say command
>> -               trap_SendServerCommand( -1, va("print \"server: %s\"",
>> ConcatArgs(0) ) );
>> +               trap_SendServerCommand( -1, va("print \"server: %s\n\"",
>> ConcatArgs(0) ) );
>>                return qtrue;
>>        }
>>
> As currently written, this will put the closing " on a new line. Was this
> intentional or should it be \"\n instead.
> ______________________________**_________________
> ioquake3 mailing list
> ioquake3@lists.ioquake.org
> http://lists.ioquake.org/**listinfo.cgi/ioquake3-ioquake.**org<http://lists.ioquake.org/listinfo.cgi/ioquake3-ioquake.org>
> By sending this message I agree to love ioquake3 and libsdl.
>

It was intentional, most (all?) other places that send server "print"
commands are formated like this. The \n is for text formating, not ending
the command like the console buffer. The quotes themselves are not printed,
they are used so the message can be treated as a single token when the
command string is tokenized.

Zack Middleton
_______________________________________________
ioquake3 mailing list
ioquake3@lists.ioquake.org
http://lists.ioquake.org/listinfo.cgi/ioquake3-ioquake.org
By sending this message I agree to love ioquake3 and libsdl.

Reply via email to