Hi Jacob, I love your patch! Yet something to improve:
[auto build test ERROR on joro-iommu/next] [also build test ERROR on vkoul-dmaengine/next linux/master linus/master v5.16-rc4 next-20211208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jacob-Pan/Enable-PASID-for-DMA-API-users/20211208-063637 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: x86_64-randconfig-a013-20211208 (https://download.01.org/0day-ci/archive/20211209/[email protected]/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/018108bcd08fc145526791870b4b58edeecfca1e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jacob-Pan/Enable-PASID-for-DMA-API-users/20211208-063637 git checkout 018108bcd08fc145526791870b4b58edeecfca1e # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/dma/idxd/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): drivers/dma/idxd/init.c: In function 'idxd_enable_system_pasid': >> drivers/dma/idxd/init.c:532:10: error: implicit declaration of function >> 'iommu_enable_pasid_dma'; did you mean 'iommu_enable_nesting'? >> [-Werror=implicit-function-declaration] 532 | pasid = iommu_enable_pasid_dma(&idxd->pdev->dev); | ^~~~~~~~~~~~~~~~~~~~~~ | iommu_enable_nesting drivers/dma/idxd/init.c: In function 'idxd_disable_system_pasid': >> drivers/dma/idxd/init.c:544:2: error: implicit declaration of function >> 'iommu_disable_pasid_dma' [-Werror=implicit-function-declaration] 544 | iommu_disable_pasid_dma(&idxd->pdev->dev); | ^~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +532 drivers/dma/idxd/init.c 527 528 static int idxd_enable_system_pasid(struct idxd_device *idxd) 529 { 530 u32 pasid; 531 > 532 pasid = iommu_enable_pasid_dma(&idxd->pdev->dev); 533 if (pasid == INVALID_IOASID) { 534 dev_err(&idxd->pdev->dev, "No kernel DMA PASID\n"); 535 return -ENODEV; 536 } 537 idxd->pasid = pasid; 538 539 return 0; 540 } 541 542 static void idxd_disable_system_pasid(struct idxd_device *idxd) 543 { > 544 iommu_disable_pasid_dma(&idxd->pdev->dev); 545 idxd->pasid = 0; 546 } 547 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
