On Fri, Mar 19, 2021 at 12:52:02PM +0000, Robin Murphy wrote: > Rather than have separate opaque setter functions that are easy to > overlook and lead to repetitive boilerplate in drivers, let's pass the > relevant initialisation parameters directly to iommu_device_register(). > > Signed-off-by: Robin Murphy <robin.mur...@arm.com> > --- > drivers/iommu/amd/init.c | 3 +-- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 +--- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 5 +--- > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 5 +--- > drivers/iommu/exynos-iommu.c | 5 +--- > drivers/iommu/fsl_pamu_domain.c | 4 +-- > drivers/iommu/intel/dmar.c | 4 +-- > drivers/iommu/intel/iommu.c | 3 +-- > drivers/iommu/iommu.c | 7 ++++- > drivers/iommu/ipmmu-vmsa.c | 6 +---- > drivers/iommu/msm_iommu.c | 5 +--- > drivers/iommu/mtk_iommu.c | 5 +--- > drivers/iommu/mtk_iommu_v1.c | 4 +-- > drivers/iommu/omap-iommu.c | 5 +--- > drivers/iommu/rockchip-iommu.c | 5 +--- > drivers/iommu/s390-iommu.c | 4 +-- > drivers/iommu/sprd-iommu.c | 5 +--- > drivers/iommu/sun50i-iommu.c | 5 +--- > drivers/iommu/tegra-gart.c | 5 +--- > drivers/iommu/tegra-smmu.c | 5 +--- > drivers/iommu/virtio-iommu.c | 5 +--- > include/linux/iommu.h | 29 ++++----------------- > 22 files changed, 31 insertions(+), 98 deletions(-)
I was worried this might blow up with !CONFIG_IOMMU_API, but actually it all looks fine and is much cleaner imo so: Acked-by: Will Deacon <w...@kernel.org> Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu