> +int iommu_device_register(struct iommu_device *iommu, const struct iommu_ops > *ops,
It would be nice to avoid the pointlessly overlong line here. > + struct device *hwdev) > { > + iommu->ops = ops; > + if (hwdev) > + iommu->fwnode = hwdev->fwnode; This function could use a kerneldoc comment now. Especially the hwdev agument isn't exactly obvious. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu