Hi Emil, > -----Original Message----- > From: Emil Medve [mailto:emilian.me...@freescale.com] > Sent: Friday, January 30, 2015 7:49 PM > To: Sethi Varun-B16395; iommu@lists.linux-foundation.org; > j...@8bytes.org; jroe...@suse.de > Subject: Re: [PATCH 11/26] iommu/fsl: Fix checkpatch type OOM_MESSAGE > > Hello Varun, > > > On 01/30/2015 03:43 AM, Sethi Varun-B16395 wrote: > > Hi Emil, > > > >> -----Original Message----- > >> From: Emil Medve [mailto:emilian.me...@freescale.com] > >> Sent: Wednesday, January 28, 2015 8:05 PM > >> To: iommu@lists.linux-foundation.org; j...@8bytes.org; > >> jroe...@suse.de; Sethi Varun-B16395 > >> Cc: Medve Emilian-EMMEDVE1 > >> Subject: [PATCH 11/26] iommu/fsl: Fix checkpatch type OOM_MESSAGE > >> > >> WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' > message > >> + if (!data) { > >> + dev_err(&pdev->dev, "PAMU isr data memory allocation > >> + failed\n"); > >> > >> Signed-off-by: Emil Medve <emilian.me...@freescale.com> > >> --- > >> drivers/iommu/fsl_pamu.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c > >> index > >> 4f1926b..6f9c976 100644 > >> --- a/drivers/iommu/fsl_pamu.c > >> +++ b/drivers/iommu/fsl_pamu.c > >> @@ -1041,7 +1041,6 @@ static int __init fsl_pamu_probe(struct > >> platform_device *pdev) > >> > >> data = kzalloc(sizeof(*data), GFP_KERNEL); > >> if (!data) { > >> - dev_err(&pdev->dev, "PAMU isr data memory allocation > >> failed\n"); > >> ret = -ENOMEM; > >> goto error; > >> } > > I think this is fine, there are other places as well where we have > > error prints while setting the ENOMEM as the return code. > > This is a checkpatch report and I quote from the log:
Acked-by: Varun Sethi <varun.se...@freescale.com> _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
