Hi Emil, > -----Original Message----- > From: Emil Medve [mailto:emilian.me...@freescale.com] > Sent: Friday, January 30, 2015 12:26 PM > To: Sethi Varun-B16395; iommu@lists.linux-foundation.org; > j...@8bytes.org; jroe...@suse.de > Subject: Re: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations > > Hello Varun, > > > On 01/30/2015 12:46 AM, Sethi Varun-B16395 wrote: > > Hi Emil, > > > >> -----Original Message----- > >> From: Emil Medve [mailto:emilian.me...@freescale.com] > >> Sent: Wednesday, January 28, 2015 8:05 PM > >> To: iommu@lists.linux-foundation.org; j...@8bytes.org; > >> jroe...@suse.de; Sethi Varun-B16395 > >> Cc: Medve Emilian-EMMEDVE1 > >> Subject: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* > >> annotations > >> > >> Signed-off-by: Emil Medve <emilian.me...@freescale.com> > >> --- > >> drivers/iommu/fsl_pamu.c | 12 ++++++------ > >> drivers/iommu/fsl_pamu_domain.c | 2 +- > >> 2 files changed, 7 insertions(+), 7 deletions(-) > >> > >> diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c > >> index d958e65..652c34d 100644 > >> --- a/drivers/iommu/fsl_pamu.c > >> +++ b/drivers/iommu/fsl_pamu.c > >> @@ -50,7 +50,7 @@ struct pamu_isr_data { > >> > >> static struct paace *ppaact; > >> static struct paace *spaact; > >> -static struct ome *omt; > >> +static struct ome *omt __initdata; > > > > [varun] omt shouldn't be initdata. > > It seems to be used only from probe()'s call tree: fsl_pamu_probe() and > setup_omt(); both __init functions. Am I missing something? > > Omt corresponds to PAMU operation mapping table, which is pointed to by the PAMU OMT base registers. We are using operation mapping table for operation translation.
-Varun _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
