On 13/06/2019 15:51, Rowan Collins wrote:
In this case, you already did "wait until later" - you waited until the client saw it, and had the time and inclination to mention it to you. There are far better solutions out there, as others have mentioned, that make sure*you* see the message in good time. Then you can call up the client and say "don't use this screen I think it's corrupting the data", rather than them calling you up after they've entered 1000 corrupted records.
Still can't establish why the 'deprecated' message resulted in the image upload failing to complete. The message was down to a missing 'static' on a function that was triggered by the image metadata combined with the 'auto-rotate' of that particular image. Actually the image did not want to be rotated but that is another matter. Plug in the missing 'static' and the image loads, rotates and thumbnails. But without the message it was not obvious the load had not completed. As it happens the next batch of images did not see the problem which is obviously why it had been missed. I had to go back to the image that I'd already manually fixed and reload it to see the problem for myself :( Can you ever guarantee perfect coverage of testing?
Several other sites are using the same code so one might expect it to have turned up sooner and this machine has been through 7.0 and is now running 7.2 so in this case am I just being clobbered by not picking it up when moving from PHP5? A lot of the original single use functions have grown static versions over the years since the deprecation and I suspect there may still be others that may need work :(
By the way the site I posted originally has been completely down since I emailed them about it ... which is annoying as I want to chase the order I placed Monday ...
-- Lester Caine - G8HFL ----------------------------- Contact - https://lsces.uk/wiki/Contact L.S.Caine Electronic Services - https://lsces.uk Model Engineers Digital Workshop - https://medw.uk Rainbow Digital Media - https://rainbowdigitalmedia.uk -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
