On 04.09.2018 at 13:44, Andrey Andreev wrote: > On Mon, Sep 3, 2018 at 6:13 PM, Christoph M. Becker <cmbecke...@gmx.de> wrote: > >> On 03.09.2018 at 17:02, Andrey Andreev wrote: >> >>> I raised this issue back in January[1], but then got distracted and >>> completely forgot about it ... sorry about that. >> >> Thanks for having raised the issue. :) >> >>> Would the change target 7.3 or 7.4? >> >> IMO, we should target master (i.e. 7.4) only. >> >>> [1] https://externals.io/message/101626 > > Well, bummer. Now I feel real guilty about not acting on time, > especially since you yourself were fine with bumping to ICU 4.6 for > PHP 7.2.2 at the time. > > I know we're past feature freeze, but can we maybe do 4.6 in 7.3 and > then 50 in 7.4? We already know ICU 4.6 works well and older versions > aren't widespread; it's not like it needs extensive evaluation.
I don't see a real issue here. If anybody using PHP 7.3 (or even 7.2) still uses a very old ICU, than they get the deprecation warning. If they change to INTL_IDNA_VARIANT_UTS46, they quickly notice that it doesn't work, and likely look up in the PHP manual (where it should already have been documented that INTL_IDNA_VARIANT_UTS46 required ICU ≥ 4.6; I'll catch up on this soon), so they have the choice to upgrade their ICU, or to stick with the deprecation warning. Only for PHP 7.4 it is important to require at least ICU 4.6, since otherwise changing the default of the $variant parameter would not be possible. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
