On Tue, Nov 28, 2017 at 1:17 PM, Sebastian Bergmann <sebast...@php.net> wrote:
> Am 28.11.2017 um 13:56 schrieb Frank Denis: > > Commit: c05cbd1e775fa69ed9939796a908390f2bfb4459 > > Author: Frank Denis <git...@pureftpd.org> Tue, 28 Nov 2017 > 13:56:11 +0100 > > Parents: c219991c77e4c68f7d62963e18a1da778de0bbe0 > > Branches: PHP-7.2 > > > > Link: http://git.php.net/?p=php-src.git;a=commitdiff;h= > c05cbd1e775fa69ed9939796a908390f2bfb4459 > > > > Log: > > ext/sodium: throw exceptions instead of errors > > I am very much in favor of this change. However, making such a change in > PHP 7.2.1 is a BC break. Any chance to get that into PHP 7.2.0? > > I agree that this is a BC break in bug fixing release and should be reverted from PHP-7.2 IMO and kept in master only (whatever the change is - error or exception...) CC'd Frank... Cheers Jakub
