Le 28/11/2017 à 15:27, Christian Schneider a écrit : >> >> I am very much in favor of this change. However, making such a change in >> PHP 7.2.1 is a BC break. Any chance to get that into PHP 7.2.0? > > I'm wary of turning errors into exceptions because code which was returning a > result with libsodium before (either PECL or PHP 7.2.0) - even though it was > generating an E_WARNING/E_ERROR - now suddenly aborts with an exception.
I agree this change is quite bad... > Would you still consider an exception a good idea if the minimum value for > one of the function parameters is increased in a later version of libsodium? I think a simple warning + value increased to a sane value should be enough (could be done in PHP side, of course better if done in the library) Remi.
signature.asc
Description: OpenPGP digital signature
