Hi Pierre, Niklas On Sun, Aug 7, 2016 at 9:20 PM, Pierre Joye <pierre....@gmail.com> wrote: > I would not rush it into 7.1. On Mon, Aug 8, 2016 at 12:20 AM, Niklas Keller <m...@kelunik.com> wrote: > Isn't it a bit late to target 7.1 anyway?
I feel the same way indeed. However, it does not change existing feature at all, but this is a pure addition. It's one of the largest mandatory piece that PHP is missing. It's good for 7.1.0, IMO. (Another largest piece is escaping API for basic needs. e.g. we don't even have JavaScript string escape API.) I made choices for targeted version, 7.1.0 or 7.2.0 https://wiki.php.net/rfc/add_validate_functions_to_filter If this RFC is passed for 7.2.0, then we can adjust the feature until its release. > But anything proposed is already possible very easily in userland. This part is debatable. To implement feature that provides filter_require_*() and validation filter behavior with them, users have to write many lines of code. Some features are hard to implement in user code such as INT/OCTAL/HEX overflow detection. > I see them as conditions flow not errors per se but flow. > Invalid options could raise exceptions but it brings inconsistencies with the > other filter functions. I really think we should have Exception handling standard in CODING_STANDARD, too. This issue could be handled by PHP 8.0 or PHP 7.2. > I feel like this rfc needs more discussions and maybe we will add more things > to filter as well. Validation filters with new functions are made to work conservative way. So it would not be a issue relaxing them later. Use of exception is issue. IMO, it would be more useful if there is filter validation exception object that has more details in it. i.e. Offensive input key, data, filter name and filter options, remove filter_get_invalid_key(). I may add the new exception, FilterValidateException. (I choose "Validate" here, since most exceptions will be raised by validation filters) In fact, I don't like the way exception works currently. I'll add mentioned FilterValidateException before vote. Does this make you feel better? I feel the feature is fully implemented if I add FilterValidateException. Regards, P.S. There is conflicting pressures on RFC. I need to minimize changes so that reviewer can understand the RFC easily, but I would like to implement feature fully. Some changes cannot add/work well individually. This exception issue is one of them, another is https://wiki.php.net/rfc/precise_session_management It includes mandatory feature for proper/secure session management and implements all possible features that would be required. Yet, it is declined :( -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
