Morning all, Good idea, +1 for just doing it ...
Cheers Joe On Sat, Aug 6, 2016 at 8:18 AM, Dmitry Stogov <dmi...@zend.com> wrote: > I don't see a big problem accepting this. The change is really minor, and > makes sense. > > Dmitry. > > On Aug 6, 2016 5:26 AM, Davey Shafik <da...@php.net> wrote: > Hey all, > > I know this is a little late in the process, but it's something I've > noticed while prepping some content around 7.1. > > This RFC: https://wiki.php.net/rfc/too_few_args > > Passed, and has been implemented, but I feel that throwing an `\Error` > exception is a mistake. I think we should another more concrete exception > class for this error: > > `\TooFewArgumentsError extends \Error` > > A use case where this may trivially occur is where you are using argument > unpacking and the unpacked array is too small. Writing this, just looks bad: > > try { > foo(… $args); > } catch (\Error $e) { } > > compared: > > try { > foo(… $args); > } catch (\TooFewArgumentsError $e) { } > > Thoughts? Dmitry? > > Given the tiny change this is, and that is backwards compatible with the > original RFC, I would like to add this to 7.1 for beta3. > > I think I can make this change myself. > > - Davey > > > >
