Hi Andrea, On Jan 5, 2016 12:16 AM, "Andrea Faulds" <a...@ajf.me> wrote: > > Hi Davey, > > > Davey Shafik wrote: >> >> However, Rasmus raised the possibility of adding HTTP/2 support to the >> cli-server [2], and (someone? @php-pulls) suggested we pull in a third >> party lib to do the heavy lifting [3]. >> >> My recommendation would be to use libnghttp2 [4] which curl also uses — >> however, as this adds a new dependency, I think it should be optional (e.g. >> --with-nghttp2-dir=[PATH]), with it falling back to the current HTTP/1.x >> implementation. >> >> We could also add a flag (e.g. --[no-]http2) on the CLI for >> enabling/disabling it — this would be helpful for testing HTTP/2 client >> fallback when it's not supported. > > > Hmm, this would mean a new dependency, and more potential complexity. I'm not sure if HTTP/2 justifies it. > > Also, don't all the major client implementations of HTTP/2 require TLS? Or is localhost given a free pass?
To me it would be a huge and hard work to reinvent the wheel by manually implement http2 support. This library is widely used and well maintained. It provides all we need (easy api for frames, push and co, hpack etc.). It is an acceptable trade off to add one dep to have a compliant http2 support. > >> >> This is a much more useful tool than relying on node for make tests, and >> allows us to test adding HTTP/2 support to ext/curl, the HTTP stream (which >> could also use libnghttp2…), userland HTTP/2 clients, pecl_http (if that's >> still a thing), etc. > > > If added, I suppose it would be useful for PHP developers testing HTTP/2 features like Server Push, assuming the CLI server supported it. > > Thanks. > > -- > Andrea Faulds > https://ajf.me/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
