I've reworked your patch https://github.com/php/php-src/pull/1662 Actually, you patch was really good. I just re-factored one base data-structure "mistake" and fixed another obvious mistake in reflection. Anyway, this needs to be re-viewed by others. I'll do it myself on next week :)
Thanks. Dmitry. On Thu, Dec 3, 2015 at 7:09 PM, Dmitry Stogov <dmi...@zend.com> wrote: > OK. thanks. I'll try to find time to do this on next week. > In any case I'll give a chance to review the future patch. > Somebody might get other good improvement ideas and we don't have to hurry > now :) > > Thanks. Dmitry. > > On Thu, Dec 3, 2015 at 6:46 PM, Sean DuBois <s...@siobud.com> wrote: > >> Hi Dmitry! >> Thanks for the quickly reply. >> >> That is a bummer that the patch isn't gonna work! But yes, please go >> ahead and take it on! You don't have to show me the PR (I am happy with >> what ever you choose to do). There are some >> tests so once every passes I will be excited to see it merge :) >> >> On Thu, Dec 03, 2015 at 12:29:50PM +0300, Dmitry Stogov wrote: >> > Hi Sean, >> > >> > Although the RFC is accepted, the patch has to be significantly >> reworked. >> > Probably, it's going to be better and faster if I do it myself. >> > Let me know, if you are agree (I'll do this when I have time, and show >> you >> > PR before commit). >> > >> > Thanks. Dmitry. >> > >> > On Tue, Oct 20, 2015 at 8:36 PM, Sean DuBois <s...@siobud.com> wrote: >> > >> > > Hey list, >> > > >> > > Time for a simple RFC (in theory)! >> > > >> > > I would like to add visibility modifiers to class constants, and then >> > > as a nice added bonus give more info from the Reflection API >> (constants >> > > now are a dedicated class so nice things like doc comments) >> > > >> > > https://wiki.php.net/rfc/class_const_visibility >> > > >> > > thanks! >> > > >> > > -- >> > > PHP Internals - PHP Runtime Development Mailing List >> > > To unsubscribe, visit: http://www.php.net/unsub.php >> > > >> > > >> > >
