Hi Anatol, Thanks!
For what I see it should have no impact, either mem usage or perf but when such offset is used, in 64bit. However some numbers are better, could you provide some using exclusively this syntax and using common apps pls? Only to be sure. Cheers, Pierre On Aug 31, 2014 1:57 PM, "Anatol Belski" <anatol....@belski.net> wrote: > On Fri, August 29, 2014 18:34, Xinchen Hui wrote: > > On Fri, Aug 29, 2014 at 11:49 PM, Anatol Belski <anatol....@belski.net> > > wrote: > > > >> Hi, > >> > >> > >> while refining the big string support, it turned out that we've an > >> issue. The syntax like $s[42] = 'x'; is currently inconsistend, because > >> we have uint32 for string offsets. This actually means, the behaviour is > >> currently only available in the old style and can handle not more than > >> 2gb big > >> strings. > >> > >> Also discussed with Laruence on IRC and he actually expressed the > >> concern that we pay overhead on that. From my side I was investigating > >> on that and could suggest several solutions for that: > >> > >> - stay with the old behavior (indexes would be able to handle only 2gb > >> strings, this is the status quo) > > > > I think it's okey. maybe throw a warning if it's bigger than 32bits? > > > > > > Here's a patch http://belski.net/phpz/64_str_offset.patch fixing the the > 64 bit offsets. Please take a look, maybe we'd have a perspective with it. > So far the test suite tells no difference. > > Thanks > > Anatol >
