Hi! > Why would a non-internals person want to build PHP from git? That’s
Why not? It's an open-source project, isn't it? People may prefer using git, many integration systems (including PHP's own composer) rely on git. > just making things harder on themselves. Besides PHP itself (should > my proposal succeed), you need other extra dependencies, including a > lexer generator if Nikita’s proposal succeeds. It's like "since we depend on gcc, adding more dependencies is no problem". Doesn't make any sense to me, adding dependencies makes it harder, so it is more problems. Especially with recursive dependencies. > 1. We avoid git tracking generated files that don’t provide > meaningful diffs and that can have massive changes just from changing > the source code or the generation script. > 2. It’s no longer necessary to manually generate the VM every time an > opcode is modified. (Less debugging pain if you forget.) That's not an advantage. Having extra file in git is no problem at all, we don't pay per byte, and somebody who can't handle regenerating the VM file should not be messing with the VM (for one, they would notice the problem immediately on running the test for the change locally, and if they don't test the changes locally we probably don't want these changes). And it's not like we change the VM every day. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
