Hi! Spinning this discussion (removing generated VM from git) off into its own thread.
On 26 Aug 2014, at 21:12, Nikita Popov <nikita....@gmail.com> wrote: > -1 on removing zend_vm_execute.h. Having to install php before I can build > php would be very inconvenient. I’d point out PHP already requires extra dependencies (and your proposal adds one further) before building PHP from git. I also doubt it would cause inconvenience to developers, as if you’re developing PHP you need a stable PHP install anyway. You wouldn’t need PHP to build PHP for most cases, only if you’re building it from git. On 26 Aug 2014, at 21:08, Stas Malyshev <smalys...@sugarcrm.com> wrote: > That would make building PHP for non-internals person harder and the > list of dependencies they need to get right longer. While providing zero > added value. And yes, there are a lot of non-internals persons building > PHP. Sometimes they may even use git. Why would a non-internals person want to build PHP from git? That’s just making things harder on themselves. Besides PHP itself (should my proposal succeed), you need other extra dependencies, including a lexer generator if Nikita’s proposal succeeds. >> That would make PHP a dependency to build PHP, but it would hardly be >> the first language which is reliant on itself to be built. Are there > > It would not be the first, but why do it? It works just fine right now, > why break it? The advantages are twofold: 1. We avoid git tracking generated files that don’t provide meaningful diffs and that can have massive changes just from changing the source code or the generation script. 2. It’s no longer necessary to manually generate the VM every time an opcode is modified. (Less debugging pain if you forget.) > >> any distributions out there in which PHP is not available? > > There are systems that aren't Linux and don't have PHP as standard > package, yes. OK, that’s true. But on such systems the release package would still build. -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
