As it is not that bad for trunk, I think we should wait a bit before commiting this patch, there are still need for discussions and we should give some time to other people to comment the feature (the implementation is trivial as this stage). Sebastian, mind to revert it until we are done with the discussions?
On Tue, Jan 17, 2012 at 2:15 PM, Jan Dolecek <juzna...@gmail.com> wrote: > Sebastian, thanks for the commit. But actually as I see the tests, I > may have not specified it enough: > > ReflectionClass::setFinal(false) removes the final from the class, not > it's methods. > > This test case > http://svn.php.net/viewvc/php/php-src/trunk/ext/reflection/tests/ReflectionClass_setFinal.phpt?view=markup&pathrev=322390 > should have: > > final class a { // class is final > public function b() { // method is not > ... > } > } > > Thanks > > Jan Dolecek > juzna...@gmail.com > > > > On Tue, Jan 17, 2012 at 12:28 PM, Sebastian Bergmann <sebast...@php.net> > wrote: >> Am 17.01.2012 12:03, schrieb jpauli: >>> The patch just adds setFinal() to ReflectionClass. >>> What about ReflectionMethod? >> >> From the patch >> >> +/* {{{ proto public void ReflectionMethod::setFinal([bool isFinal = true]) >> + Sets/unsets class as final */ >> +ZEND_METHOD(reflection_method, setFinal) >> >> +/* {{{ proto public void ReflectionClass::setFinal([bool isFinal = true]) >> + Sets/unsets class as final */ >> +ZEND_METHOD(reflection_class, setFinal) >> >> >> TL;DR: All is well :) >> >> -- >> Sebastian Bergmann Co-Founder and Principal Consultant >> http://sebastian-bergmann.de/ http://thePHP.cc/ >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
