hi Jan! Patch looks good, but coding standard.
Please always use brackets, even for one line condition (if () foo else bar). Cheers, On Mon, Jan 16, 2012 at 7:06 PM, Jan Dolecek <juzna...@gmail.com> wrote: > Hi, > > reflection is a great tool for testing, but it still misses support > for mocking classes/methods marked as final. I created a small patch > https://gist.github.com/1621839#file_php_finals.patch, examples how to > use it https://gist.github.com/1621839#file_final_test.php and wrote a > short article explaining it: > http://blog.juzna.cz/2012/01/mock-vs-final-fights-in-testing/. > > Can you include it into svn pls? > Thanks > > Jan Dolecek > juzna...@gmail.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
