Hi
On Tue, 27 Dec 2011 13:26:59 +0100, Derick Rethans <der...@php.net> wrote:
On Mon, 26 Dec 2011, Antony Dovgal wrote:
On 12/26/2011 12:40 PM, Derick Rethans wrote:
> I'll have a look when I get back home. Is there anything else you
> want me to look at?
Yes!
https://bugs.php.net/bug.php?id=53437 =)
I've just had a look at the patch, and it seems to encode things in
weird stuff for DatePeriod (packed ints, base64)?!.
Not for DatePeriod, for DateInterval. The problem is that the DateInterval
object uses 64-bit integers in its structure, and you can't serialize them
as normal PHP integers if you want to have no data corruption in
architectures with 32-bit longs like Windows. You seemed to have ignored
that difficulty when you later implemented DateInterval serialization. My
implementation also does state validation on DateInterval::__wakeup.
It also seems to re-implement the DateInterval serialisation and the
patch doesn't cleanly apply.
Well, the patch is against r305891 (HEAD at the time), DateInterval
serialization was implemented in r320481.
In any case, if you want to use only the DatePeriod part (which provides
serialization and properties), it should work independently from the
DateInterval portion.
--
Gustavo Lopes
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
