Stas Malyshev <smalys...@sugarcrm.com> wrote:

> Hi!
> 
> I see that test for bug 52062 (marked as fixed by this commit: 
> http://svn.php.net/viewvc/?view=revision&amp;revision=320481) now
> fails 
> on my 32-bit system. Looking at the patch and the test, it can not 
> actually succeed, as the test expects this:
> int(100000000000)
> which is not possible on 32-bit system, and the code actually compares
> 
> the result to LONG_MAX which is 32-bit and returns false when it's 
> bigger that that. So I'd like to know what was the intent there:
> 
> 1. Return false on 32-bit and the test should be fixed to account for 
> 32-bit and 64-bit?
> 2. Return float on 32-bit?
> 3. Do something else?
> 
> Please advise.
> -- 
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

I'll have a look when I get back home. Is there anything else you want me to 
look at?

cheers,
Derick

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to