On Wed, Aug 24, 2011 at 8:02 PM, Stas Malyshev <smalys...@sugarcrm.com> wrote: > Hi! > > On 8/24/11 10:56 AM, pierre....@gmail.com wrote: >> >> What are you talking about? The change is exactly about that, change the >> behavior when a string is passed. > > Code relying on passing string to is_a is buggy, since it is clearly > documented as accepting object. That's what I am talking about. If your code > relies on that, it has a bug, fix it.
As it was working perfectly fine until now, it was perfectly fine to use is_a only to valid possible instances of a given class, passing a non object returned false, which was totally correct (per se). Now call that a bug, fine, but it is a breakage in a patch release. >> We are back to the discussion about undeprecating is_a, from scratch... > > No we're not. It is not deprecated, nobody proposes to deprecate it - how > we're back? About why it should not suddenly changes this working perfectly fine before. And about not calling autoload. Arguments have been given, by many and in all possible ways. I do not see a consensus coming out (while Zeev just realized what we are talking about when we say 'breakage'). I propose to go for a vote to see what we should do with this fix in the 5.3 branch. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
