On Wed, Aug 24, 2011 at 11:33 PM, Stas Malyshev <smalys...@sugarcrm.com> wrote: > Hi! > > Thanks for providing the timeline. > > On 8/24/11 2:15 PM, Ferenc Kovacs wrote: >> >> 5, Helgi fixed Pear in the meanwhile >> >> http://svn.php.net/viewvc/pear/pear-core/tags/PEAR-1.9.5/PEAR.php?r1=313081&r2=313083&pathrev=313340 > > This fix doesn't look good - it doesn't do what is was meant to do.
/o\, I didn't noticed it until you mentioned... > >> 7, Helgi reverts the Pear fix >> >> http://svn.php.net/viewvc/pear/pear-core/tags/PEAR-1.9.5/PEAR.php?r1=313340&r2=313339&pathrev=313340 > > And this should be using instanceof instead. yep, I think the main reason that is_a was used in the first place is the fact that instanceof was added with php 5... obviously there is no point in watching out for php4 compatibility anymore. or at least it shouldn't be. -- Ferenc Kovács @Tyr43l - http://tyrael.hu -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
